From abe6ab477531916158c04e3d387cb02e839d28b6 Mon Sep 17 00:00:00 2001 From: zotlabs Date: Fri, 23 Mar 2018 21:24:24 -0700 Subject: logic fallacy when updating parent timestamp of moderated comment --- include/items.php | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/include/items.php b/include/items.php index 53d1a3c02..a2068868a 100755 --- a/include/items.php +++ b/include/items.php @@ -1977,11 +1977,19 @@ function item_store($arr, $allow_exec = false, $deliver = true) { */ call_hooks('post_remote_end', $arr); + $update_parent = true; + // update the commented timestamp on the parent - unless this is a moderated comment or a potential clone of an older item // which we don't wish to bring to the surface. As the queue only holds deliveries for 3 days, it's // suspected of being an older cloned item if the creation time is older than that. - if((intval($arr['item_blocked']) != ITEM_MODERATED) || ($arr['created'] > datetime_convert('','','now - 4 days'))) { + if(intval($arr['item_blocked']) === ITEM_MODERATED) + $update_parent = false; + + if($arr['created'] < datetime_convert('','','now - 4 days')) + $update_parent = false; + + if($update_parent) { $z = q("select max(created) as commented from item where parent_mid = '%s' and uid = %d and item_delayed = 0 ", dbesc($arr['parent_mid']), intval($arr['uid']) -- cgit v1.2.3