From 4c4db6f73cc6702d26fbbea85ff45eb91fb20a0c Mon Sep 17 00:00:00 2001 From: zottel Date: Fri, 27 Nov 2015 10:35:31 +0100 Subject: added info about Apache settings to avoid Apache running wild --- install/INSTALL.txt | 41 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/install/INSTALL.txt b/install/INSTALL.txt index c81510522..25852497b 100644 --- a/install/INSTALL.txt +++ b/install/INSTALL.txt @@ -341,3 +341,44 @@ This is obvious as soon as you notice that the cron uses proc_open to execute php-scripts that also use proc_open, but it took me quite some time to find that out. I hope this saves some time for other people using suhosin with function blacklists. + +##################################################################### +- Apache processes hanging, using as much CPU as they can +##################################################################### + +This seems to happen sometimes if you use mpm_prefork and the PHP process +started by Apache cannot get database access. + +Consider the following settings: + +In /etc/apache2/mods-enabled/mpm_prefork.conf (Debian, path and file name +may vary depending on your OS and distribution), set + + GracefulShutdownTimeout 300 + +This makes sure that Apache processes that are running wild will not do so +forever, but will be killed if they didn't stop five minutes after a +shutdown command was sent to the process. + +If you expect high load on your server (public servers, e.g.), also make +sure that Apache will not spawn more processes than MySQL will accept +connections. + +In the default Debian configuration, in +/etc/apache2/mods-enabled/mpm_prefork.conf the maximum number of workers +is set to 150: + + MaxRequestWorkers 150 + +However, in /etc/mysql/my.cnf the maximum number of connection is set to +100: + + max_connections = 100 + +150 workers are a lot and probably too much for small servers. However you +set those values, make sure that the number of Apache workers is smaller +than the number of connections MySQL accepts, leaving some room for other +stuff on your server that might access MySQL, and Hubzilla's poller which +needs MySQL access, too. A good setting for a medium-sized hub might be to +keep MySQL's max_connections at 100 and set mpm_prefork's +MaxRequestWorkers to 70. -- cgit v1.2.3 From ee153f64d459406f429a8951e95ec0d50fa66956 Mon Sep 17 00:00:00 2001 From: Mario Vavti Date: Fri, 27 Nov 2015 13:32:20 +0100 Subject: add spinner to events --- view/css/mod_events.css | 5 +++++ view/tpl/event_head.tpl | 4 ++++ view/tpl/events-js.tpl | 3 ++- 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/view/css/mod_events.css b/view/css/mod_events.css index 5e0fc2bce..9644a5593 100644 --- a/view/css/mod_events.css +++ b/view/css/mod_events.css @@ -4,6 +4,11 @@ margin-bottom: -1px; } +#events-spinner .spinner { + margin-top: 9px; + margin-bottom: -9px; +} + .bootstrap-tagsinput { width: 100%; padding: 6px 12px; diff --git a/view/tpl/event_head.tpl b/view/tpl/event_head.tpl index 6a38057fd..745cdc0e6 100755 --- a/view/tpl/event_head.tpl +++ b/view/tpl/event_head.tpl @@ -55,7 +55,11 @@ showEvent(calEvent.id); }, loading: function(isLoading, view) { + $('#events-spinner').spin('tiny'); + $('#events-spinner > i').css('color', 'transparent'); if(!isLoading) { + $('#events-spinner').spin(false); + $('#events-spinner > i').css('color', 'unset'); $('td.fc-day').dblclick(function() { openMenu('form'); //window.location.href='/events/new?start='+$(this).data('date'); diff --git a/view/tpl/events-js.tpl b/view/tpl/events-js.tpl index b2de90da1..2b6170ff4 100755 --- a/view/tpl/events-js.tpl +++ b/view/tpl/events-js.tpl @@ -1,12 +1,13 @@
+
- +
-- cgit v1.2.3 From 61a5e81bc62d8517a1c7a86249c0a1e9a42fe1d8 Mon Sep 17 00:00:00 2001 From: Mario Vavti Date: Fri, 27 Nov 2015 13:55:02 +0100 Subject: only show edit icon for your own events and minoe cleanup --- mod/events.php | 21 +++------------------ 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/mod/events.php b/mod/events.php index 64d7dfb93..080c39911 100755 --- a/mod/events.php +++ b/mod/events.php @@ -90,7 +90,7 @@ function events_post(&$a) { linkify_tags($a, $desc, local_channel()); linkify_tags($a, $location, local_channel()); - $action = ($event_hash == '') ? 'new' : "event/" . $event_hash; + //$action = ($event_hash == '') ? 'new' : "event/" . $event_hash; //fixme: this url gives a wsod if there is a linebreak detected in one of the variables ($desc or $location) //$onerror_url = $a->get_baseurl() . "/events/" . $action . "?summary=$summary&description=$desc&location=$location&start=$start_text&finish=$finish_text&adjust=$adjust&nofinish=$nofinish&type=$type"; @@ -376,39 +376,24 @@ function events_content(&$a) { if(x($orig_event)) $tz = (($orig_event['adjust']) ? date_default_timezone_get() : 'UTC'); -// $syear = ((x($orig_event)) ? datetime_convert('UTC', $tz, $sdt, 'Y') : '0000'); -// $smonth = ((x($orig_event)) ? datetime_convert('UTC', $tz, $sdt, 'm') : '00'); -// $sday = ((x($orig_event)) ? datetime_convert('UTC', $tz, $sdt, 'd') : '00'); - $syear = datetime_convert('UTC', $tz, $sdt, 'Y'); $smonth = datetime_convert('UTC', $tz, $sdt, 'm'); $sday = datetime_convert('UTC', $tz, $sdt, 'd'); - -// $shour = ((x($orig_event)) ? datetime_convert('UTC', $tz, $sdt, 'H') : '00'); -// $sminute = ((x($orig_event)) ? datetime_convert('UTC', $tz, $sdt, 'i') : '00'); - $shour = datetime_convert('UTC', $tz, $sdt, 'H'); $sminute = datetime_convert('UTC', $tz, $sdt, 'i'); $stext = datetime_convert('UTC',$tz,$sdt); $stext = substr($stext,0,14) . "00:00"; -// $fyear = ((x($orig_event)) ? datetime_convert('UTC', $tz, $fdt, 'Y') : '0000'); -// $fmonth = ((x($orig_event)) ? datetime_convert('UTC', $tz, $fdt, 'm') : '00'); -// $fday = ((x($orig_event)) ? datetime_convert('UTC', $tz, $fdt, 'd') : '00'); - $fyear = datetime_convert('UTC', $tz, $fdt, 'Y'); $fmonth = datetime_convert('UTC', $tz, $fdt, 'm'); $fday = datetime_convert('UTC', $tz, $fdt, 'd'); - -// $fhour = ((x($orig_event)) ? datetime_convert('UTC', $tz, $fdt, 'H') : '00'); -// $fminute = ((x($orig_event)) ? datetime_convert('UTC', $tz, $fdt, 'i') : '00'); - $fhour = datetime_convert('UTC', $tz, $fdt, 'H'); $fminute = datetime_convert('UTC', $tz, $fdt, 'i'); $ftext = datetime_convert('UTC',$tz,$fdt); $ftext = substr($ftext,0,14) . "00:00"; + $type = ((x($orig_event)) ? $orig_event['type'] : 'event'); $f = get_config('system','event_input_format'); @@ -608,7 +593,7 @@ function events_content(&$a) { $last_date = $d; - $edit = array($a->get_baseurl().'/events/'.$rr['event_hash'].'?expandform=1',t('Edit event'),'',''); + $edit = ((local_channel() && $rr['author_xchan'] == get_observer_hash()) ? array($a->get_baseurl().'/events/'.$rr['event_hash'].'?expandform=1',t('Edit event'),'','') : false); $drop = array($a->get_baseurl().'/events/drop/'.$rr['event_hash'],t('Delete event'),'',''); -- cgit v1.2.3 From e569f5d6ebc44b8bd6011e8ec2db757188b51c48 Mon Sep 17 00:00:00 2001 From: Mario Vavti Date: Fri, 27 Nov 2015 14:00:37 +0100 Subject: unset does not work in webkit browsers --- view/tpl/event_head.tpl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/view/tpl/event_head.tpl b/view/tpl/event_head.tpl index 745cdc0e6..dc98d14b3 100755 --- a/view/tpl/event_head.tpl +++ b/view/tpl/event_head.tpl @@ -59,7 +59,7 @@ $('#events-spinner > i').css('color', 'transparent'); if(!isLoading) { $('#events-spinner').spin(false); - $('#events-spinner > i').css('color', 'unset'); + $('#events-spinner > i').css('color', ''); $('td.fc-day').dblclick(function() { openMenu('form'); //window.location.href='/events/new?start='+$(this).data('date'); -- cgit v1.2.3 From f691e8981af3632e54b77739ee64ef86a7436aea Mon Sep 17 00:00:00 2001 From: Mario Vavti Date: Fri, 27 Nov 2015 20:55:27 +0100 Subject: fixes #194 - New directory server is selected on every directory page reload --- include/dir_fns.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/dir_fns.php b/include/dir_fns.php index b9f221bd1..fd2a5835d 100644 --- a/include/dir_fns.php +++ b/include/dir_fns.php @@ -22,7 +22,7 @@ function find_upstream_directory($dirmode) { $r = q("select * from site where site_url = '%s' limit 1", dbesc($preferred) ); - if(($r) && ($r[0]['site_flags'] & DIRECTORY_MODE_STADALONE)) { + if(($r) && ($r[0]['site_flags'] & DIRECTORY_MODE_STANDALONE)) { $preferred = ''; } } -- cgit v1.2.3 From b92cc852d142940f0f8dd78ddf7be835dc8b9e07 Mon Sep 17 00:00:00 2001 From: Mario Vavti Date: Fri, 27 Nov 2015 21:44:02 +0100 Subject: css fixes --- view/css/bootstrap-red.css | 3 +- view/css/mod_events.css | 13 +++++++ view/theme/redbasic/css/style.css | 78 ++++----------------------------------- 3 files changed, 23 insertions(+), 71 deletions(-) diff --git a/view/css/bootstrap-red.css b/view/css/bootstrap-red.css index 19796679a..29164c7ad 100644 --- a/view/css/bootstrap-red.css +++ b/view/css/bootstrap-red.css @@ -57,7 +57,8 @@ nav .navbar-toggle { /* nav overrides end */ -aside .nav-pills > li > a { +aside .nav-pills > li > a, +.response-list .nav-pills > li > a { padding: 6px 10px; } diff --git a/view/css/mod_events.css b/view/css/mod_events.css index 9644a5593..dd1b8afd4 100644 --- a/view/css/mod_events.css +++ b/view/css/mod_events.css @@ -19,3 +19,16 @@ height: auto; padding: 10px; } + +.event-owner { + margin-bottom: 15px; +} + +.event-owner img { + margin-right: 5px; +} + +.event-buttons, +.event-description { + margin-top: 10px; +} diff --git a/view/theme/redbasic/css/style.css b/view/theme/redbasic/css/style.css index fe6f10365..e392f00d9 100644 --- a/view/theme/redbasic/css/style.css +++ b/view/theme/redbasic/css/style.css @@ -241,7 +241,8 @@ footer { padding-right: 3em; } -.birthday-today, .event-today { +.birthday-today, +.event-today { font-weight: bold; } @@ -847,68 +848,6 @@ nav .acpopup { cursor: pointer; } -.fc-unthemed th, -.fc-unthemed td, -.fc-unthemed thead, -.fc-unthemed tbody, -.fc-unthemed .fc-divider, -.fc-unthemed .fc-row, -.fc-unthemed .fc-popover { - border-color: #ccc !important; -} - -.wall-event-item { - padding: 10px; - color: #fff; - background-color: #3A87AD; /* should reflect calendar color */ - border-top-left-radius: $radiuspx; - border-top-right-radius: $radiuspx; -} - -.vevent .event-end { - padding-bottom: 10px; -} - -#event-summary-text { - margin-top: 15px; -} - - -#new-event-link { - margin-bottom: 10px; -} - -.edit-event-link, .plink-event-link, .drop-event-link { - float: left; - margin-top: 4px; - margin-right: 4px; - margin-bottom: 15px; -} - -.event-owner img { - padding-bottom: 10px; - padding-right: 10px; -} - -.event-buttons { - margin-top: 10px; -} - -.event-list-date { - margin-bottom: 10px; -} - -.prevcal, .nextcal { - float: left; - margin-left: 32px; - margin-right: 32px; - margin-top: 64px; -} -.event-calendar-end { - clear: both; -} - - #cboxOverlay { z-index: 1050; } @@ -1562,8 +1501,12 @@ img.mail-conv-sender-photo { padding: 0.5em 10px; } -.wall-photo-item { - /*padding: 0.5em 10px;*/ +.wall-event-item { + padding: 10px; + color: #fff; + background-color: #3A87AD; /* should reflect calendar color */ + border-top-left-radius: $radiuspx; + border-top-right-radius: $radiuspx; } .wall-photo-item img { @@ -2252,8 +2195,3 @@ nav .badge.mail-update:hover { .help-searchlist a { font-size: 130%; } - -.response-list ul { - list-style-type: none; -} - -- cgit v1.2.3 From bcfa72ed310f05dc9a5fca9e724c07b7216aa7fd Mon Sep 17 00:00:00 2001 From: Mario Vavti Date: Fri, 27 Nov 2015 22:45:28 +0100 Subject: move events tools to aside widget --- include/widgets.php | 16 +++++++++++++++- view/css/mod_events.css | 18 ++++++++++++++++++ view/pdl/mod_events.pdl | 1 + view/tpl/events-js.tpl | 16 ---------------- view/tpl/events_side.tpl | 8 -------- 5 files changed, 34 insertions(+), 25 deletions(-) delete mode 100755 view/tpl/events_side.tpl diff --git a/include/widgets.php b/include/widgets.php index a3f7444ec..d4f3d32e1 100644 --- a/include/widgets.php +++ b/include/widgets.php @@ -666,7 +666,7 @@ function widget_eventsmenu($arr) { if (! local_channel()) return; - return replace_macros(get_markup_template('events_side.tpl'), array( + return replace_macros(get_markup_template('events_menu_side.tpl'), array( '$title' => t('Events Menu'), '$day' => t('Day View'), '$week' => t('Week View'), @@ -677,6 +677,18 @@ function widget_eventsmenu($arr) { )); } +function widget_eventstools($arr) { + if (! local_channel()) + return; + + return replace_macros(get_markup_template('events_tools_side.tpl'), array( + '$title' => t('Events Tools'), + '$export' => t('Export Calendar'), + '$import' => t('Import Calendar'), + '$submit' => t('Submit') + )); +} + function widget_design_tools($arr) { $a = get_app(); @@ -1147,6 +1159,8 @@ function widget_forums($arr) { function widget_tasklist($arr) { + if (! local_channel()) + return; require_once('include/event.php'); $o .= ''; diff --git a/view/css/mod_events.css b/view/css/mod_events.css index dd1b8afd4..dc1dc902f 100644 --- a/view/css/mod_events.css +++ b/view/css/mod_events.css @@ -4,6 +4,16 @@ margin-bottom: -1px; } +.fc-unthemed th, +.fc-unthemed td, +.fc-unthemed thead, +.fc-unthemed tbody, +.fc-unthemed .fc-divider, +.fc-unthemed .fc-row, +.fc-unthemed .fc-popover { + border-color: #ccc !important; +} + #events-spinner .spinner { margin-top: 9px; margin-bottom: -9px; @@ -32,3 +42,11 @@ .event-description { margin-top: 10px; } + +#event-upload-form { + margin-top: 10px; +} + +#event-upload-choose { + width: 100%; +} diff --git a/view/pdl/mod_events.pdl b/view/pdl/mod_events.pdl index 5a71d88d9..a3bc0c019 100644 --- a/view/pdl/mod_events.pdl +++ b/view/pdl/mod_events.pdl @@ -1,4 +1,5 @@ [region=aside] [widget=eventsmenu][/widget] +[widget=eventstools][/widget] [widget=tasklist][/widget] [/region] diff --git a/view/tpl/events-js.tpl b/view/tpl/events-js.tpl index 2b6170ff4..08c8aa64a 100755 --- a/view/tpl/events-js.tpl +++ b/view/tpl/events-js.tpl @@ -1,10 +1,7 @@
- - -
@@ -17,19 +14,6 @@ -
diff --git a/view/tpl/events_side.tpl b/view/tpl/events_side.tpl deleted file mode 100755 index b9a9062b1..000000000 --- a/view/tpl/events_side.tpl +++ /dev/null @@ -1,8 +0,0 @@ -
-

{{$title}}

- -
-- cgit v1.2.3 From fce1dc083b0d6d8294463b9e698924f6f53593cd Mon Sep 17 00:00:00 2001 From: Mario Vavti Date: Fri, 27 Nov 2015 22:53:36 +0100 Subject: add templates --- view/tpl/events_menu_side.tpl | 8 ++++++++ view/tpl/events_tools_side.tpl | 15 +++++++++++++++ 2 files changed, 23 insertions(+) create mode 100755 view/tpl/events_menu_side.tpl create mode 100755 view/tpl/events_tools_side.tpl diff --git a/view/tpl/events_menu_side.tpl b/view/tpl/events_menu_side.tpl new file mode 100755 index 000000000..b9a9062b1 --- /dev/null +++ b/view/tpl/events_menu_side.tpl @@ -0,0 +1,8 @@ +
+

{{$title}}

+ +
diff --git a/view/tpl/events_tools_side.tpl b/view/tpl/events_tools_side.tpl new file mode 100755 index 000000000..5e20511fc --- /dev/null +++ b/view/tpl/events_tools_side.tpl @@ -0,0 +1,15 @@ +
+

{{$title}}

+ + +
-- cgit v1.2.3 From 16e7ec7bfea0de778d5eb0d0f5ab5a51aa10c480 Mon Sep 17 00:00:00 2001 From: ken restivo Date: Fri, 27 Nov 2015 14:38:29 -0800 Subject: Safe defaults to prevent #188 --- .htaccess | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.htaccess b/.htaccess index 7f3935117..3bc14d74d 100644 --- a/.htaccess +++ b/.htaccess @@ -28,3 +28,9 @@ AddType audio/ogg .oga RewriteCond %{REQUEST_FILENAME} !-d RewriteRule ^(.*)$ index.php?q=$1 [E=REMOTE_USER:%{HTTP:Authorization},L,QSA] + + +# Required to keep Apache from hanging waiting for MySql connections + + GracefulShutdownTimeout 300 + \ No newline at end of file -- cgit v1.2.3 From aa78d51521132cf38e8c6a52cd01345e41f67905 Mon Sep 17 00:00:00 2001 From: ken restivo Date: Fri, 27 Nov 2015 14:40:22 -0800 Subject: More sane defaults, to avoid problems. Addresses #188 --- .htaccess | 1 + 1 file changed, 1 insertion(+) diff --git a/.htaccess b/.htaccess index 3bc14d74d..237e0caef 100644 --- a/.htaccess +++ b/.htaccess @@ -33,4 +33,5 @@ AddType audio/ogg .oga # Required to keep Apache from hanging waiting for MySql connections GracefulShutdownTimeout 300 + MaxRequestWorkers 100 \ No newline at end of file -- cgit v1.2.3 From 4af104384b5f97eeacd1426f158304f6956002af Mon Sep 17 00:00:00 2001 From: ken restivo Date: Fri, 27 Nov 2015 14:43:17 -0800 Subject: Re-reading zottel's excellent docs, 70 seems the recommended default. Changed. --- .htaccess | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.htaccess b/.htaccess index 237e0caef..e22b860fd 100644 --- a/.htaccess +++ b/.htaccess @@ -33,5 +33,5 @@ AddType audio/ogg .oga # Required to keep Apache from hanging waiting for MySql connections GracefulShutdownTimeout 300 - MaxRequestWorkers 100 + MaxRequestWorkers 70 \ No newline at end of file -- cgit v1.2.3 From 216d41cd642890cbfdadc092e5f944d788d91843 Mon Sep 17 00:00:00 2001 From: ken restivo Date: Fri, 27 Nov 2015 16:32:32 -0800 Subject: Reverted. --- .htaccess | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.htaccess b/.htaccess index e22b860fd..5f6414882 100644 --- a/.htaccess +++ b/.htaccess @@ -29,9 +29,3 @@ AddType audio/ogg .oga RewriteRule ^(.*)$ index.php?q=$1 [E=REMOTE_USER:%{HTTP:Authorization},L,QSA] - -# Required to keep Apache from hanging waiting for MySql connections - - GracefulShutdownTimeout 300 - MaxRequestWorkers 70 - \ No newline at end of file -- cgit v1.2.3