Merge branch 'dev' of https://framagit.org/hubzilla/core into dev

2 files changed, 48 insertions, 50 deletions

diff --git a/include/help.php b/include/help.php
index f2aa4add3..61dbc7bb3 100644
--- a/include/help.php
+++ b/include/help.php
@@ -12,12 +12,12 @@ use \Michelf\MarkdownExtra;
 function get_help_fullpath($path,$suffix=null) {
 
         $docroot = (\App::$override_helproot) ? \App::$override_helproot : 'doc/';
-        $docroot = (substr($docroot,-1)!='/') ? $docroot .= '/' : $docroot; 
+        $docroot = (substr($docroot,-1)!='/') ? $docroot .= '/' : $docroot;
 
         // Determine the language and modify the path accordingly
         $x = determine_help_language();
         $lang = $x['language'];
-        $url_idx = ($x['from_url'] ? 1 : 0);
+
         // The English translation is at the root of /doc/. Other languages are in
         // subfolders named by the language code such as "de", "es", etc.
         if($lang !== 'en') {
@@ -53,15 +53,14 @@ function get_help_fullpath($path,$suffix=null) {
  * @return string|unknown
  */
 function get_help_content($tocpath = false) {
-	global $lang;
 
 	$doctype = 'markdown';
 
 	$text = '';
 
 	$path = (($tocpath !== false) ? $tocpath : '');
-        $docroot = (\App::$override_helproot) ? \App::$override_helproot : 'doc/';
-        $docroot = (substr($docroot,-1)!='/') ? $docroot .= '/' : $docroot; 
+	$docroot = (\App::$override_helproot) ? \App::$override_helproot : 'doc/';
+	$docroot = (substr($docroot,-1)!='/') ? $docroot .= '/' : $docroot;
 
 	if($tocpath === false && argc() > 1) {
 		$path = '';
@@ -74,7 +73,7 @@ function get_help_content($tocpath = false) {
 
 
 	if($path) {
-                $fullpath = get_help_fullpath($path);
+		$fullpath = get_help_fullpath($path);
 		$title = basename($path);
 		if(! $tocpath)
 			\App::$page['title'] = t('Help:') . ' ' . ucwords(str_replace('-',' ',notags($title)));
@@ -88,10 +87,10 @@ function get_help_content($tocpath = false) {
 			load_doc_file($fullpath . '.md') === '' &&
 			load_doc_file($fullpath . '.bb') === '' &&
 			load_doc_file($fullpath . '.html') === ''
-		  ) {
+		) {
 			$path = $title;
 		}
-                $fullpath = get_help_fullpath($path);
+		$fullpath = get_help_fullpath($path);
 		$text = load_doc_file($fullpath . '.md');
 
 		if(! $text) {
@@ -111,15 +110,15 @@ function get_help_content($tocpath = false) {
 
 	if($tocpath === false) {
 		if(! $text) {
-                        $path = 'Site';
-                        $fullpath = get_help_fullpath($path,'.md');
+			$path = 'Site';
+			$fullpath = get_help_fullpath($path,'.md');
 			$text = load_doc_file($fullpath . '.md');
 			\App::$page['title'] = t('Help');
 		}
 		if(! $text) {
 			$doctype = 'bbcode';
-                        $path = 'main';
-                        $fullpath = get_help_fullpath($path,'.md');
+			$path = 'main';
+			$fullpath = get_help_fullpath($path,'.md');
 			$text = load_doc_file($fullpath . '.bb');
 			goaway('/help/about/about');
 			\App::$page['title'] = t('Help');
@@ -219,7 +218,6 @@ function find_doc_file($s) {
  */
 function search_doc_files($s) {
 
-
 	\App::set_pager_itemspage(60);
 	$pager_sql = sprintf(" LIMIT %d OFFSET %d ", intval(\App::$pager['itemspage']), intval(\App::$pager['start']));
 
@@ -351,7 +349,7 @@ function store_doc_file($s) {
 		$x = item_store_update($item);
 	}
 	else {
-		$item['uuid'] = $item_message_id();
+		$item['uuid'] = item_message_id();
 		$item['mid'] = $item['parent_mid'] = z_root() . '/item/' . $item['uuid'];
 		$x = item_store($item);
 	}
diff --git a/include/plugin.php b/include/plugin.php
index 7eeb39ce8..ec14fd945 100755
--- a/include/plugin.php
+++ b/include/plugin.php
@@ -213,8 +213,8 @@ function reload_plugins() {
 								try {
 										$func();
 								} catch (Exception $e) {
-									handleerrors_plugin($plugin,"","UNLOAD FAILED (uninstalling) : ".$e->getMessage(),true);
-																		continue;
+									handleerrors_plugin($pl, '', 'UNLOAD FAILED (uninstalling) : ' . $e->getMessage(),true);
+									continue;
 								}
 							}
 							if(function_exists($pl . '_load')) {
@@ -222,8 +222,8 @@ function reload_plugins() {
 								try {
 										$func();
 								} catch (Exception $e) {
-									handleerrors_plugin($plugin,"","LOAD FAILED (uninstalling): ".$e->getMessage(),true);
-																		continue;
+									handleerrors_plugin($pl, '', 'LOAD FAILED (uninstalling): ' . $e->getMessage(),true);
+									continue;
 								}
 							}
 							q("UPDATE addon SET tstamp = %d WHERE id = %d",
@@ -305,7 +305,7 @@ function plugins_sync() {
  * @return array
  */
 function visible_plugin_list() {
-	
+
 	$r = q("select * from addon where hidden = 0 order by aname asc");
 	$x = (($r) ? ids_to_array($r,'aname') : array());
 	$y = [];
@@ -315,7 +315,7 @@ function visible_plugin_list() {
 				$y[] = $xv;
 			}
 		}
-	}			
+	}
 	return $y;
 }
 
@@ -456,21 +456,21 @@ function insert_hook($hook, $fn, $version = 0, $priority = 0) {
 function call_hooks($name, &$data = null) {
 	$a = 0;
 
-	if (isset(App::$hooks[$name])) { 
+	if (isset(App::$hooks[$name])) {
 		foreach(App::$hooks[$name] as $hook) {
 
 			if ($name != 'permit_hook') { // avoid looping
 				$checkhook = [
- 					'name'=>$name,
- 					'hook'=>$hook,
-                                        'data'=>$data,
+ 						'name'=>$name,
+	 					'hook'=>$hook,
+						'data'=>$data,
 						// Note: Since PHP uses COPY-ON-WRITE
-                                                // for variables, there is no cost to
+						// for variables, there is no cost to
 						// passing the $data structure (unless
 						// the permit_hook processors change the
 						// information it contains.
- 					'permit'=>true
- 					];
+ 						'permit'=>true
+ 				];
  				call_hooks('permit_hook',$checkhook);
  				if (!$checkhook['permit']) {
  					continue;
@@ -618,7 +618,7 @@ function get_widget_info($widget){
 		}
 	}
 
-	if(! ($widget_found && $f))		
+	if(! ($widget_found && $f))
 		return $info;
 
 	$f = escape_tags($f);
@@ -1041,7 +1041,7 @@ function get_intltext_template($s, $root = '') {
         if (isset(\App::$override_intltext_templates[$testroot][$s]["content"])) {
                 return \App::$override_intltext_templates[$testroot][$s]["content"];
         } else {
-                if (isset(\App::$override_intltext_templates[$testroot][$s]["root"]) && 
+                if (isset(\App::$override_intltext_templates[$testroot][$s]["root"]) &&
                    isset(\App::$override_intltext_templates[$testroot][$s]["file"])) {
                         $s = \App::$override_intltext_templates[$testroot][$s]["file"];
                         $root = \App::$override_intltext_templates[$testroot][$s]["root"];
@@ -1058,30 +1058,30 @@ function get_intltext_template($s, $root = '') {
 }
 
 function get_markup_template($s, $root = '') {
-        $testroot = ($root=='') ? $testroot = "ROOT" : $root;
+	$testroot = ($root=='') ? $testroot = "ROOT" : $root;
 
-        $t = App::template_engine();
+	$t = App::template_engine();
 
-        if (isset(\App::$override_markup_templates[$testroot][$s]["content"])) {
-                return \App::$override_markup_templates[$testroot][$s]["content"];
-        } else {
-                if (isset(\App::$override_markup_templates[$testroot][$s]["root"]) && 
-                   isset(\App::$override_markup_templates[$testroot][$s]["file"])) {
-                        $root = \App::$override_markup_templates[$testroot][$s]["root"];
-                        $s = \App::$override_markup_templates[$testroot][$s]["file"];
-                	$template = $t->get_markup_template($s, $root);
-                } elseif (\App::$override_templateroot) {
-                   $newroot = \App::$override_templateroot;
-                   if ($newroot != '' && substr($newroot,-1) != '/' ) {
-                           $newroot .= '/';
-                   }
-		   $newroot .= $root;
-                   $template = $t->get_markup_template($s, $newroot);
-                } else {
-                	$template = $t->get_markup_template($s, $root);
+	if (isset(\App::$override_markup_templates[$testroot][$s]["content"])) {
+		return \App::$override_markup_templates[$testroot][$s]["content"];
+	} else {
+		if (isset(\App::$override_markup_templates[$testroot][$s]["root"]) &&
+				isset(\App::$override_markup_templates[$testroot][$s]["file"])) {
+					$root = \App::$override_markup_templates[$testroot][$s]["root"];
+					$s = \App::$override_markup_templates[$testroot][$s]["file"];
+					$template = $t->get_markup_template($s, $root);
+		} elseif (\App::$override_templateroot) {
+			$newroot = \App::$override_templateroot;
+			if ($newroot != '' && substr($newroot,-1) != '/' ) {
+				$newroot .= '/';
+			}
+			$newroot .= $root;
+			$template = $t->get_markup_template($s, $newroot);
+		} else {
+			$template = $t->get_markup_template($s, $root);
 		}
-                return $template;
-        }
+		return $template;
+	}
 }
 
 /**